Addressing registry conflicts in Makefile #3299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivkumar13
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
Shivkumar13
changed the title
jhoreman
approved these changes
Nov 29, 2023
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SudoBrendan
requested changes
Jan 16, 2024
There was a problem hiding this comment.
I worry about this change because it has wider implications to our pipelines, where this variable is set and overridden, e.g. https://github.com/Azure/ARO-RP/blob/master/.pipelines/e2e.yml#L42 (I'm sure this happens in other places too... we'd need to audit all pipelines everywhere, not just in our repo here...)
What is the pain we are trying to mitigate here? I feel like if someone doesn't run make secrets + . ./env other issues will also arise outside this.
|
Closing this since it's stale and has no associated ticket. Push back if this seems worth pursuing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the issue with the
RP_IMAGE_ACRenv, as when$(RP_IMAGE_ACR)is empty, the$ARO_IMAGE_BASEwould be.azurecr.io/aro, which will fail any operations that we do with the image.Encountered this issue while the
RP_IMAGE_ACRis not set, and also the else if conditions seems unnecessary as we are defaulting to registry.access.redhat.com in the else block so no need to checkRP_IMAGE_ACRexplicitly for the empty value.Test plan for issue:
N/A
Is there any documentation that needs to be updated for this PR?
N/A