2023-11-22 stable API (porting 07-01-preview api) #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoreman
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
jhoreman
force-pushed
the
2023-11-22-stable
branch
from
f113f14
to
f68866b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pkg/util/azureclient/mgmt/redhatopenshift/2023-11-22/redhatopenshift/openshiftclusters.go
Dismissed
Show resolved
Hide resolved
pkg/util/azureclient/mgmt/redhatopenshift/2023-11-22/redhatopenshift/operations.go
Dismissed
Show resolved
Hide resolved
tony-schndr
reviewed
Jan 15, 2024
jhoreman
force-pushed
the
2023-11-22-stable
branch
from
f68866b
to
7e64e09
Compare
jhoreman
force-pushed
the
2023-11-22-stable
branch
from
7e64e09
to
8ac47de
Compare
SudoBrendan
reviewed
Jan 15, 2024
There was a problem hiding this comment.
To future reviewers - this PR includes both the generation of the skeleton API and adding the new fields this API supports. To view what is changing here, you can run:
diff -bur v20230904/ v20231122/
and to verify that everything related to multiple public IPs (not NSG/WorkerProfile stuff) made it over, you can run:
diff -bur v20230701preview/ v20231122/
2 tasks
SudoBrendan
requested changes
Jan 15, 2024
jhoreman
changed the title
SudoBrendan
requested changes
Jan 16, 2024
|
LGTM, I went through the diffs it looks like everything is here. |
SudoBrendan
approved these changes
Jan 16, 2024
LiniSusan
pushed a commit
to LiniSusan/ARO-RP
that referenced
this pull request
Jan 25, 2024
* adding 2023-11-22 stable --------- Co-authored-by: b-jhoreman <[email protected]>
ventifus
pushed a commit
to ventifus/ARO-RP
that referenced
this pull request
Feb 7, 2024
* adding 2023-11-22 stable --------- Co-authored-by: b-jhoreman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-4613
What this PR does / why we need it:
This ports functionality from the latest preview API into a stable API definition.
Test plan for issue: