Add libzstd.so.1 to fluentbit container build #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennerv
added
bug
bennerv
requested review from
jewzaam,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
cblecker
approved these changes
Dec 1, 2023
s-fairchild
approved these changes
Dec 1, 2023
s-amann
approved these changes
Dec 1, 2023
cadenmarchese
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes fluentbit builds. I pushed over the INT ACR image so e2es will pass. We will need to rebuild and push over the existing tags for the images we broke. But we should not push over production images & tags
What this PR does / why we need it:
In the latest builds of fluentbit, there is a requirement for the shared object library
libstdz.so.1, which isn't copied into the fluentbit image. As a result, we get an crashloopbackoff when running fluentbit and e2es fail.[bvesel@fedora ARO-RP]$ oc -n openshift-azure-logging logs mdsd-b9krb -c fluentbit /opt/td-agent-bit/bin/td-agent-bit: error while loading shared libraries: libzstd.so.1: cannot open shared object file: No such file or directoryTest plan for issue:
podman build -f Dockerfile.fluentbit --build-arg MARINER_VERSION=<xyz>Is there any documentation that needs to be updated for this PR?
Nope. We should really be using image digests for these versions. Otherwise if we accidentally push over an existing version, we'll break new cluster installations and logging.