Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in disk-encryption-set.md #3323

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

mbukatov
Copy link
Contributor

Which issue this PR addresses:

None

What this PR does / why we need it:

The RP is addressing:

  • difference between des naming scheme used in e2e tests and the disk-encryption-set.md document
  • issues with az keyvault show reporting just created keyvault as not found

Test plan for issue:

No

Is there any documentation that needs to be updated for this PR?

No further edits needed.

When you follow docs/disk-encryption-set.md and then run e2e tests, test
case "[It] [Admin API] List Azure resources action must list Azure
resources for a cluster" will fail because it can't find the disk
encryption set:

```
The Resource 'Microsoft.Compute/diskEncryptionSets/mbukatov-rg-disk-encryption-set' under resource group 'mbukatov-rg' was not found.
```
@tiguelu tiguelu merged commit 38c86f8 into Azure:master Mar 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants