az aro update CredentialsRequest hotfix
#3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… immediately erroring out
operator's CredentialsRequest has been deleted
kimorris27
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
bennerv
reviewed
Dec 14, 2023
dem4gus
reviewed
Dec 14, 2023
bennerv
reviewed
Dec 14, 2023
cadenmarchese
approved these changes
Dec 14, 2023
s-amann
approved these changes
Dec 14, 2023
cadenmarchese
pushed a commit
to cadenmarchese/ARO-RP
that referenced
this pull request
Dec 14, 2023
* If the CredentialsRequest isn't found, retry until timeout instead of immediately erroring out * `ensureCredentialsRequest` upon every `az aro update` * Add an E2E test for the `az aro update` scenario where the ARO operator's CredentialsRequest has been deleted
ventifus
pushed a commit
to ventifus/ARO-RP
that referenced
this pull request
Feb 7, 2024
* If the CredentialsRequest isn't found, retry until timeout instead of immediately erroring out * `ensureCredentialsRequest` upon every `az aro update` * Add an E2E test for the `az aro update` scenario where the ARO operator's CredentialsRequest has been deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Issue where
az aro update --refresh-credentialsfails becausecredentialsrequest/openshift-azure-operatordoesn't exist (for clusters not yet updated to use the new ARO operator Azure auth scheme; see #3274)What this PR does / why we need it:
az aro updateregardless of the auth scheme the operator is using or whether the update is a CSP refreshing updatearoCredentialsRequestReconciledfunction to retry until the timeout if the CredentialsRequest is not found (as opposed to erroring out immediately)Test plan for issue:
az aro update --refresh-credentialsaz aro updaterecreates a missing CredentialsRequest (did not include the CSP refresh in this test)Is there any documentation that needs to be updated for this PR?
No