Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ensureAccessTokenClaims #3337

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

nwnt
Copy link
Contributor

@nwnt nwnt commented Dec 22, 2023

Which issue this PR addresses:

Fixes: N/A, just adding unit tests.

What this PR does / why we need it:

Adding unit tests for the ensureAccessTokenClaims function. Also adding why the function is needed.

Test plan for issue:

Unit tests ran successfully.

Is there any documentation that needs to be updated for this PR?

N/A

@nwnt nwnt force-pushed the add-unit-test-dynamic-validate branch from 56da6a0 to 0c2f429 Compare December 22, 2023 00:24
@nwnt nwnt added the next-release To be included in the next RP release rollout label Dec 22, 2023
@nwnt
Copy link
Contributor Author

nwnt commented Jan 3, 2024

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jaitaiwan jaitaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go.mod Show resolved Hide resolved
@cadenmarchese cadenmarchese merged commit 5068e9d into master Jan 11, 2024
19 checks passed
@nwnt nwnt deleted the add-unit-test-dynamic-validate branch January 11, 2024 21:51
LiniSusan pushed a commit to LiniSusan/ARO-RP that referenced this pull request Jan 25, 2024
ventifus pushed a commit to ventifus/ARO-RP that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release To be included in the next RP release rollout ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants