Adjust the NSG validation logic for GA #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwnt
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
dofinn
as code owners
|
/azp run e2e |
|
No pipelines are associated with this pull request. |
|
/azp run "E2E - PullRequest" |
|
No pipelines are associated with this pull request. |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nwnt
force-pushed
the
adjust-nsg-validation
branch
from
f0a2eb6
to
939047f
Compare
cadenmarchese
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes: ARO-2590
What this PR does / why we need it:
To adjust the validation logic of NSG validation for GA. Previously in private preview, we allow no nsgs to be attached to the subnets which the FP then assumes that the feature shouldn't be used. In GA, we make it explicit so that when the preconfigured nsg flag is enabled and no subnets are attached, the FP will error out instead.
Test plan for issue:
Unit tests.
Is there any documentation that needs to be updated for this PR?
no