accept pull-secret when we use hack script to create a clsuter #3360
Conversation
bitoku
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
dofinn
as code owners
|
LGTM! |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -447,6 +447,7 @@ func (c *Cluster) createCluster(ctx context.Context, vnetResourceGroup, clusterN | |||
| ResourceGroupID: fmt.Sprintf("/subscriptions/%s/resourceGroups/%s", c.env.SubscriptionID(), "aro-"+clusterName), | |||
| FipsValidatedModules: api.FipsValidatedModulesEnabled, | |||
| Version: osClusterVersion, | |||
| PullSecret: api.SecureString(os.Getenv("USER_PULL_SECRET")), | |||
There was a problem hiding this comment.
Can we include an accompanying docs change in this PR?
We can update this one with instructions on passing in a pull secret: https://github.com/Azure/ARO-RP/blob/master/docs/deploy-development-rp.md#run-the-rp-and-create-a-cluster
There was a problem hiding this comment.
I don't think we need it, because USER_PULL_SECRET is already configured in the secret, so we don't need to set it explicitly.
And also it is not meant as a general way of configuring the pull-secret.
If we want to use other pull-secret then we can set it after creation, so we don't need to use this USER_PULL_SECRET variable.
It is only needed when we want to use a installer image stored in other place than ACR.
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
close this PR because it continues to fail E2E. |
Which issue this PR addresses:
N/A
What this PR does / why we need it:
There is no way to specify pull-secret when we use the hack script to create a cluster.
When testing the installer, if the installer image is hosted in quay.io, hive doesn't changes the domains of other images required during installation to ACR domain and it causes Authentication error if it doesn't have the pull-secret.
This pull-secret enables us to access to those images in quay.io and make the installer test convenient.
Test plan for issue:
I was able to create a cluster with ACR domain installer and quay.io domain installer.