Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate required customer service principal permissions #3361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Validate required customer service principal permissions #3361

wants to merge 1 commit into from

Conversation

rhamitarora
Copy link
Collaborator

@rhamitarora rhamitarora commented Jan 19, 2024 •
edited
Loading

Which issue this PR addresses:

Alert on loss of access rights and permissions on cluster / network resources

What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

@rhamitarora rhamitarora added work-in-progress firefly Issues or Pull requests owned by Team Firefly labels Jan 19, 2024
@rhamitarora rhamitarora force-pushed the vnet-permission-4 branch 2 times, most recently from 347f11a to 2fdbbac Compare January 22, 2024 04:08
AldoFusterTurpin
AldoFusterTurpin suggested changes Feb 14, 2024
View reviewed changes
Copy link

@AldoFusterTurpin AldoFusterTurpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is in draft mode. Just a quick comment about the panic for now. I will do a full review when it is in non draft mode. 🙂

pkg/monitor/cluster/validatepermissions.go Show resolved Hide resolved
AldoFusterTurpin
AldoFusterTurpin reviewed Feb 15, 2024
View reviewed changes
Copy link

@AldoFusterTurpin AldoFusterTurpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments pointing to things that could be causing you problems when testing it 🙂

pkg/monitor/cluster/validatepermissions_test.go Show resolved Hide resolved
pkg/monitor/cluster/validatepermissions.go Show resolved Hide resolved
pkg/monitor/cluster/validatepermissions_test.go Show resolved Hide resolved
@rhamitarora rhamitarora force-pushed the vnet-permission-4 branch 2 times, most recently from e928a67 to 4f7ef09 Compare February 19, 2024 15:57
@github-actions GitHub Actions
Copy link

Please rebase pull request.

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Feb 20, 2024
@rhamitarora rhamitarora marked this pull request as ready for review March 5, 2024 04:23
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AldoFusterTurpin AldoFusterTurpin AldoFusterTurpin requested changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@s-amann s-amann Awaiting requested review from s-amann

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@Shivkumar13 Shivkumar13 Awaiting requested review from Shivkumar13

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@dofinn dofinn Awaiting requested review from dofinn

@tiguelu tiguelu Awaiting requested review from tiguelu tiguelu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
firefly Issues or Pull requests owned by Team Firefly work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhamitarora @AldoFusterTurpin