Use the right option for the cluster client

[nwnt]

Which issue this PR addresses:

Fixes: ARO-3315

What this PR does / why we need it:

Make sure the az identity client use the right option. At the moment it's set with nil.

Test plan for issue:

E2E

Is there any documentation that needs to be updated for this PR?

No

[mociarain]

Small suggestion on it as it. On a general note I think we could consider breaking this function up into a few parts. It's quite long and essentially there are 2 parts labelled // X Validation that could be broken out easily.

What do you think?

[mociarain]

Also does this have any bearing for the linked epic?

[nwnt]

ARO-2248 is the work item to remove that after all the releases have been completed. As for the refactoring suggestion, I think it's better to keep or track that as a separate task as this one is aimed to fix the apparent bug. IMHO, that's going to be a non-trivial task because there's not a single unit test that validates this function. Probably that's a required step prior to any refactoring efforts.

[cadenmarchese]

/azp run e2e

[azure-pipelines]

No pipelines are associated with this pull request.

[cadenmarchese]

@nwnt @mociarain as discussed in review today, I think we could handle the refactor in another PR since this is a bugfix.

[mociarain]

@nwnt @mociarain as discussed in review today, I think we could handle the refactor in another PR since this is a bugfix.

Np. Happy to do the refactor myself to get the practice in. Just let me know :)

[nwnt]

/azp run e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[cadenmarchese]

/azp run e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[github-actions]

Please rebase pull request.

[nwnt]

No longer need this PR as the same fix is applied in #3335.