Do not exit NSG monitor when unable to get subnet #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
dofinn
as code owners
|
@nwnt I'd like to get your review on this approach and if this makes sense to do within the monitor, or if we should evaluate a different approach to handle this test flake. |
|
@tsatam I think this is definitely better than it currently is. Thank you very much for the improvement. |
nwnt
approved these changes
Jan 29, 2024
cadenmarchese
approved these changes
Jan 31, 2024
SudoBrendan
approved these changes
Feb 1, 2024
mociarain
pushed a commit
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Proposed behavioral change for the refactor performed in #3358
Original Jiras for feature: ARO-4892 and ARO-4967
What this PR does / why we need it:
In the NSG monitor, we currently exit early if we encounter an error when trying to retrieve a subnet. This PR changes the behavior to continue trying to evaluate the subnets and to ignore ones with errors.
The implementation as-is was causing flaky test failures, as the order of subnet evaluation was not consistent, leading to mocked Subnet GET calls not always occurring as expected.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
no