Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revendor hive to 5fbe0d158ba9 #3377

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Revendor hive to 5fbe0d158ba9 #3377

merged 3 commits into from
Feb 12, 2024

Conversation

s-fairchild
Copy link
Collaborator

@s-fairchild s-fairchild commented Feb 5, 2024 •
edited
Loading

Which issue this PR addresses:

ARO-5059

What this PR does / why we need it:

  1. Hive needs to be vendored at the same commit level as it is deployed in ARO. One reason, as described in the linked card, is that changes in APIs can lead to unintended edits during round-trip Get()/Update() flows.
  2. Increase verbosity for golangci-lint to improve general debug ability
  3. Change golangci-lint output format to be github-actions format

Is there any documentation that needs to be updated for this PR?

Updating Hive Dependency Update Wiki

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Feb 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Please rebase pull request.

@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Feb 5, 2024
@s-fairchild s-fairchild mentioned this pull request Feb 5, 2024
Closed
@s-fairchild s-fairchild added chainsaw Pull requests or issues owned by Team Chainsaw dependencies Pull requests that update a dependency file labels Feb 5, 2024
@s-fairchild
Increase golangci-lint verbosity
015b342 
Increasing golangci-lint's verbosity will make troubleshooting it's problem easier.
@s-fairchild s-fairchild force-pushed the revendor-hive branch 3 times, most recently from 73b8ddd to 043b004 Compare February 8, 2024 17:18
@s-fairchild s-fairchild marked this pull request as ready for review February 8, 2024 23:07
@s-fairchild s-fairchild added next-release To be included in the next RP release rollout release-blocker labels Feb 8, 2024
mociarain
mociarain approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Absolute pain we need to do this ever few weeks :D Thanks for handling it)

cadenmarchese
cadenmarchese requested changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@cadenmarchese cadenmarchese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good to hit approve when docs are updated!

go.mod Show resolved Hide resolved
@cadenmarchese cadenmarchese merged commit 6bd01cd into Azure:master Feb 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mociarain mociarain mociarain approved these changes

@cadenmarchese cadenmarchese cadenmarchese approved these changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@s-amann s-amann Awaiting requested review from s-amann

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@Shivkumar13 Shivkumar13 Awaiting requested review from Shivkumar13

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@dofinn dofinn Awaiting requested review from dofinn

Assignees
No one assigned
Labels
chainsaw Pull requests or issues owned by Team Chainsaw dependencies Pull requests that update a dependency file next-release To be included in the next RP release rollout ready-for-review release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-fairchild @mociarain @cadenmarchese