Update cluster lifecycle API fields to readOnly #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
force-pushed
the
ARO-4745/api-readonly-2
branch
from
f62b6a6
to
6bb479d
Compare
tsatam
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
dofinn
as code owners
tsatam
changed the title
tsatam
added
loki
ready-for-review
priority-high
SudoBrendan
approved these changes
Feb 7, 2024
…e ip, systemdata to be readonly in v20231122 API
tsatam
force-pushed
the
ARO-4745/api-readonly-2
branch
from
6bb479d
to
728e9fa
Compare
tsatam
added
release-blocker
next-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-4745
What this PR does / why we need it:
This PR sets a handful of fields in the API's OpenShiftCluster to be read only because they don't change once set. Changing the values in these fields would create unexpected functionality for the RP.
Fields changed to read-only:
.properties.consoleProfile.url.properties.apiserverProfile.url.properties.apiserverProfile.ip.properties.ingressProfiles[*].ip.systemDataThis PR differs from #3369 in that we set the entire
systemDatatop level property on the resource to read-only. This will prevent any modifications to all fields on this subresource by clients performing any PUT/POST operations.Test plan for issue:
Is there any documentation that needs to be updated for this PR?
No
Additional notes
aaznetwork client bundled with our Python extension. This code is mirrored/vendored from the Azure CLI and comes with its own license.