Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ZonalAllocationFailed #3381

Closed
wants to merge 1 commit into from

Conversation

rhamitarora
Copy link
Collaborator

@rhamitarora rhamitarora commented Feb 6, 2024

Which issue this PR addresses:

https://issues.redhat.com/browse/ARO-4867

What this PR does / why we need it:

Implements a pattern for handling Hive install failures in the RP, and handles one specific case (Azure ZonalAllocationFailed) errors.

Test plan for issue:

Unit tests have been added for the specific Hive install failure cases implemented within the PR.

Is there any documentation that needs to be updated for this PR?

This PR is soft-dependent on a PR to our Hive deployment pipeline in order to add the additional-install-log-regexes ConfigMap to its deployment artifacts.
And ICMAutomation PR to not alert when ZonalAllocationFailed related failures are the reason for a deployment failure.

@rhamitarora rhamitarora added work-in-progress firefly Issues or Pull requests owned by Team Firefly labels Feb 6, 2024
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the look of it :) but I need to be able to read the ticket and get the surrounding details so I can better understand and review these changes. Can you add some context to this?

Sorry! Didn't realise this was at draft stage.

@mociarain mociarain dismissed their stale review February 6, 2024 09:08

Sorry I just realised this was a draft. My bad

@rhamitarora rhamitarora force-pushed the zonalallocationfailed branch 3 times, most recently from 02b3c27 to 40de7c0 Compare February 8, 2024 18:19
@rhamitarora rhamitarora marked this pull request as ready for review March 5, 2024 03:52
@rhamitarora rhamitarora requested a review from tsatam March 6, 2024 03:01
Copy link

Please rebase pull request.

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Mar 19, 2024
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 2 questions:

  • Do the other ARO-Pipelines needs need to be merged first?
  • Do we need to run a hive release before we run an RP release once both of these are merged?

@rhamitarora rhamitarora deleted the zonalallocationfailed branch July 15, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firefly Issues or Pull requests owned by Team Firefly needs-rebase branch needs a rebase work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants