-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for ZonalAllocationFailed #3381
Conversation
531c743
to
981c4b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the look of it :) but I need to be able to read the ticket and get the surrounding details so I can better understand and review these changes. Can you add some context to this?
Sorry! Didn't realise this was at draft stage.
Sorry I just realised this was a draft. My bad
02b3c27
to
40de7c0
Compare
40de7c0
to
38792ae
Compare
Please rebase pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 2 questions:
- Do the other ARO-Pipelines needs need to be merged first?
- Do we need to run a hive release before we run an RP release once both of these are merged?
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-4867
What this PR does / why we need it:
Implements a pattern for handling Hive install failures in the RP, and handles one specific case (Azure ZonalAllocationFailed) errors.
Test plan for issue:
Unit tests have been added for the specific Hive install failure cases implemented within the PR.
Is there any documentation that needs to be updated for this PR?
This PR is soft-dependent on a PR to our Hive deployment pipeline in order to add the additional-install-log-regexes ConfigMap to its deployment artifacts.
And ICMAutomation PR to not alert when ZonalAllocationFailed related failures are the reason for a deployment failure.