Clearer E2E stack traces #3382
Closed
Clearer E2E stack traces #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
This is a small PR to improve the readability of E2E test output by using the
GinkgoHelper(). I noticed this feature while doing https://issues.redhat.com/browse/ARO-5321. The details are here but the tl;dr is we get more informative/clearer stack traces if there is an error in the helpers.What this PR does / why we need it:
To get access to the
GinkgoHelper()I needed to bump Ginkgo to 2.8.0 (currently at 2.7.0) and while I was at it I went all the way to 2.14.0.Note: 2.15.0 is out but requires Go 1.20.0.
Test plan for issue:
The current E2E tests.
Is there any documentation that needs to be updated for this PR?
No. I think having this in the existing helpers is enough documentation.