Update images to Go 1.20 #3385
Closed
Update images to Go 1.20 #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
dofinn
as code owners
|
@hawkowl can you make sure our images in the Azure image registries we use for ev2 are updated as well? See the CDPx Container Images wiki page in ADO. |
|
@bennerv done |
hawkowl
force-pushed
the
hawkowl/update-go-120
branch
from
6c58a70
to
ab15b68
Compare
hawkowl
force-pushed
the
hawkowl/update-go-120
branch
2 times, most recently
from
863ece3
to
4107f08
Compare
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hawkowl
added
ready-for-review
skippy
|
Moved the ancillary changes into #3413 |
|
Will wait to review once 3413 is merged. |
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
hawkowl
force-pushed
the
hawkowl/update-go-120
branch
from
2ce571d
to
c0d1510
Compare
|
@jaitaiwan should be good to review now |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hawkowl
force-pushed
the
hawkowl/update-go-120
branch
from
e016b37
to
c827bcb
Compare
dofinn
reviewed
Mar 5, 2024
| @@ -35,8 +33,6 @@ func usage() { | |||
| } | |||
|
|
|||
| func main() { | |||
| rand.Seed(time.Now().UnixNano()) | |||
There was a problem hiding this comment.
@hawkowl this should be replaced with rand.New(rand.NewSource(seed)) as per https://tip.golang.org/doc/go1.20#:~:text=the%20standard%20library.-,math/rand,-The%20math/rand ?
There was a problem hiding this comment.
Why? rand.New returns a new rand source, it doesn't modify the global one. As per the go 1.20 docs, it's automatically seeded.
dofinn
reviewed
Mar 5, 2024
| @@ -14,7 +14,7 @@ pr: none | |||
| variables: | |||
| Cdp_Definition_Build_Count: $[counter('', 0)] # needed for onebranch.pipeline.version task https://aka.ms/obpipelines/versioning | |||
| ONEBRANCH_AME_ACR_LOGIN: cdpxb8e9ef87cd634085ab141c637806568c00.azurecr.io | |||
| LinuxContainerImage: $(ONEBRANCH_AME_ACR_LOGIN)/b8e9ef87-cd63-4085-ab14-1c637806568c/official/ubi8/go-toolset:1.18.4 # Docker image which is used to build the project https://aka.ms/obpipelines/containers | |||
| LinuxContainerImage: $(ONEBRANCH_AME_ACR_LOGIN)/b8e9ef87-cd63-4085-ab14-1c637806568c/official/ubi8/go-toolset:1.20.10 # Docker image which is used to build the project https://aka.ms/obpipelines/containers | |||
|
/lgtm |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-5320
What this PR does / why we need it:
Updates images to Go 1.20, fixes build problems and CI/lint issues from Go 1.20.
Test plan for issue:
Should be covered by e2e, unit tests, etc
Is there any documentation that needs to be updated for this PR?
N/A