Changes for retry logic - Min Worker Node Err #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiniSusan
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
dofinn and
tiguelu
as code owners
This was referenced Mar 15, 2024
Closed
Closed
mociarain
reviewed
Mar 18, 2024
| cnd, cndErr := c.f(ctx) | ||
| if errors.Is(cndErr, wait.ErrWaitTimeout) { | ||
| cnd, retry, cndErr := c.f(ctx) | ||
| if errors.Is(cndErr, wait.ErrWaitTimeout) && !retry { |
There was a problem hiding this comment.
Why do we need this extra retry over the existing retry logic this has?
|
Also this might be helpful with the CI: https://redhat-internal.slack.com/archives/C02ULBRS68M/p1710774666598769 |
bitoku
reviewed
Mar 18, 2024
There was a problem hiding this comment.
I think it lacks the explanation how is the retry handled.
At first I thought that it indicates whether the error is retryable or not, but the logic doesn't seem so.
If you want to tell the wait.Poll* function if the condition is retryable, ConditionFunc can return (false, nil) for retryable error and (false, err) for non-retryable error.
https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait#PollImmediateUntil
|
Please rebase pull request. |
|
What's the current state of this? Can I help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-4247
Fixes
Report meaningful error for "minimum worker nodes not created" errors
What this PR does / why we need it:
As of now RP is providing only generic error if the cluster install got failed due to insufficient number of worker nodes. If meaningful error or specific error is provided then will be easy to correct it and proceed the cluster installation.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?