Minimal Python container to build az aro extension
#3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
dofinn and
tiguelu
as code owners
SudoBrendan
previously approved these changes
Apr 1, 2024
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Please rebase pull request. |
tsatam
force-pushed
the
tsatam/ARO-5088-python-multistage-containerfile
branch
from
3b4e7bf
to
70e1d7e
Compare
tsatam
force-pushed
the
tsatam/ARO-5088-python-multistage-containerfile
branch
from
70e1d7e
to
c16b4f2
Compare
SudoBrendan
requested changes
Jun 5, 2024
tsatam
force-pushed
the
tsatam/ARO-5088-python-multistage-containerfile
branch
from
c16b4f2
to
10d3bff
Compare
tsatam
force-pushed
the
tsatam/ARO-5088-python-multistage-containerfile
branch
from
10d3bff
to
c2d1aaa
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
tsatam
force-pushed
the
tsatam/ARO-5088-python-multistage-containerfile
branch
from
c2d1aaa
to
257e1cd
Compare
SudoBrendan
approved these changes
Jun 6, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR recreates #3439 off of in-repository branch for CI checks)
Which issue this PR addresses:
Small step for ARO-5088
What this PR does / why we need it:
az aroextension with no other dependenciesTest plan for issue:
Manually invoke target and ensure it creates an
aro-${VERSION}-py2.py3-none-any.whlfile within./python/az/aro/dist.Is there any documentation that needs to be updated for this PR?
Eventually, https://msazure.visualstudio.com/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/188187/AzureCLI-preview-extension-publishing# should be updated to include this target.
Additional Notes
azdevcommand (style/linter/test).azdevrequires that it be run within the context of a Git repository, as well as from within a specific virtualenv.