Load the app/SP from the environment instead of automatically creating it #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
dofinn and
tiguelu
as code owners
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mociarain
approved these changes
Apr 4, 2024
tsatam
previously approved these changes
Apr 4, 2024
mociarain
requested changes
Apr 4, 2024
s-fairchild
previously approved these changes
Apr 4, 2024
|
/azp run ci e2e |
|
No pipelines are associated with this pull request. |
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run e2e, ci |
|
Azure Pipelines successfully started running 2 pipeline(s). |
s-amann
approved these changes
Apr 5, 2024
mociarain
approved these changes
Apr 5, 2024
tsatam
approved these changes
Apr 5, 2024
| get_cluster_sp() { | ||
| echo "########## Downloading SP secrets ##########" | ||
|
|
||
| az keyvault secret download --vault-name=aro-e2e-principals \ |
There was a problem hiding this comment.
Not blocking the PR, but we should add a TODO here for eventually grabbing a single SP among the entire pool
jhoreman
pushed a commit
that referenced
this pull request
Apr 8, 2024
…g it (#3498) * use multierror here, so it's more obvious if we're missing multiple keys * Ignore the written out clusterapp.env * move create/delete into separate commands, which write out a clusterapp.env file * delete the app in the e2e.sh file * update the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Part of ARO-5822
What this PR does / why we need it:
Loads the application and SP secret from the env, instead of automatically creating it. This allows us to load them from a fixed pool in the e2e process, instead of creating new ones each time.
Test plan for issue:
Manually tested creating a cluster locally with the steps updated in the docs
Is there any documentation that needs to be updated for this PR?
Updated dev RP docs
How do you know this will function as expected in production?
Purely CI/E2E/dev changes -- more will need to happen for prod e2e