Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-cli coordinates in mirror #3501

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

tsatam
Copy link
Collaborator

@tsatam tsatam commented Apr 4, 2024

Which issue this PR addresses:

No Jira

What this PR does / why we need it:

Updates our image reference for the Azure CLI to a known working version

Test plan for issue:

  • mirroring pipeline works

Is there any documentation that needs to be updated for this PR?

No

How do you know this will function as expected in production?

N/A (image only used ad-hoc)

Copy link
Contributor

@tiguelu tiguelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Small, nit. Is there any other doc that references this image that we need to update apart from https://dev.azure.com/msazure/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/553880/MDM-MDSD-and-Fluentbit-image-refresh ?

@tiguelu
Copy link
Contributor

tiguelu commented Apr 4, 2024

LGTM.

Small, nit. Is there any other doc that references this image that we need to update apart from https://dev.azure.com/msazure/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/553880/MDM-MDSD-and-Fluentbit-image-refresh ?

Disregard that comment, this was a different image unrelated to the image being mirrored.

@tsatam
Copy link
Collaborator Author

tsatam commented Apr 4, 2024

Small, nit. Is there any other doc that references this image that we need to update apart from https://dev.azure.com/msazure/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/553880/MDM-MDSD-and-Fluentbit-image-refresh ?

Good point, we have various ad-hoc SOPs that instruct us to utilize the Azure CLI image, some of them provide specific coordinates while others do not.

We should replace any explicit occurrences of azure-cli:2 with azure-cli:cbl-mariner2.0 in documentation.

@tiguelu
Copy link
Contributor

tiguelu commented Apr 4, 2024

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@UlrichSchlueter UlrichSchlueter merged commit 162164e into master Apr 4, 2024
18 checks passed
@tiguelu
Copy link
Contributor

tiguelu commented Apr 4, 2024

Small, nit. Is there any other doc that references this image that we need to update apart from https://dev.azure.com/msazure/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/553880/MDM-MDSD-and-Fluentbit-image-refresh ?

Good point, we have various ad-hoc SOPs that instruct us to utilize the Azure CLI image, some of them provide specific coordinates while others do not.

We should replace any explicit occurrences of azure-cli:2 with azure-cli:cbl-mariner2.0 in documentation.

I changed a direct reference to the image in upstream repo in one SOP, and found another 4 referencing the ACR image. Raised ARO-6728 to update them after a successful mirroring happens.

@tiguelu tiguelu deleted the tsatam/hotfix-update-azure-cli-image branch April 4, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants