-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure-cli coordinates in mirror #3501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Small, nit. Is there any other doc that references this image that we need to update apart from https://dev.azure.com/msazure/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/553880/MDM-MDSD-and-Fluentbit-image-refresh ?
Disregard that comment, this was a different image unrelated to the image being mirrored. |
Good point, we have various ad-hoc SOPs that instruct us to utilize the Azure CLI image, some of them provide specific coordinates while others do not. We should replace any explicit occurrences of |
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
I changed a direct reference to the image in upstream repo in one SOP, and found another 4 referencing the ACR image. Raised ARO-6728 to update them after a successful mirroring happens. |
Which issue this PR addresses:
No Jira
What this PR does / why we need it:
Updates our image reference for the Azure CLI to a known working version
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
N/A (image only used ad-hoc)