ARO-5325: Propagate install error to user #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edisonLcardenas
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
dofinn and
tiguelu
as code owners
kimorris27
approved these changes
Apr 9, 2024
edisonLcardenas
commented
Apr 9, 2024
|
@edisonLcardenas : will these changes take the error to frontend (to user)?? |
|
|
LGTM |
rhamitarora
approved these changes
Apr 10, 2024
|
LGTM |
anshulvermapatel
approved these changes
Apr 15, 2024
|
/azp run CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes
https://issues.redhat.com/browse/ARO-5325
What this PR does / why we need it:
Propagate error to user.
Test plan for issue:
Updated runner_test.go
Is there any documentation that needs to be updated for this PR?
No, tech debt.
How do you know this will function as expected in production?
Unit test.