adding retry logic on yum commands to avoid resource locking #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoreman
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
dofinn and
tiguelu
as code owners
tsatam
reviewed
Apr 9, 2024
s-fairchild
requested changes
Apr 9, 2024
| yum -y install podman-docker | ||
| for attempt in {1..5}; do | ||
| yum update -y --disablerepo='*' --enablerepo='rhui-microsoft-azure*' && break | ||
| if [[ ${attempt} -lt 5 ]]; then sleep 10; else exit 1; fi |
There was a problem hiding this comment.
Can we break this up into multiple lines?
Single line is harder to read and not really needed here.
| echo "running yum update" | ||
| for attempt in {1..5}; do | ||
| yum -y -x WALinuxAgent -x WALinuxAgent-udev update --allowerasing && break | ||
| if [[ ${attempt} -lt 5 ]]; then sleep 10; else exit 1; fi |
There was a problem hiding this comment.
same as above for the remainder of if statements added
| yum -y -x WALinuxAgent -x WALinuxAgent-udev update | ||
| yum -y install podman-docker | ||
| for attempt in {1..5}; do | ||
| yum update -y --disablerepo='*' --enablerepo='rhui-microsoft-azure*' && break |
There was a problem hiding this comment.
I'm also a fan of breaking up script arguments into multiple lines when there are multiple.
Example:
yum update \
-y \
--disablerepo='*' \
--enablerepo='rhui-microsoft-azure*' && break
s-fairchild
approved these changes
Apr 9, 2024
hlipsig
approved these changes
Apr 9, 2024
|
/azp run ci |
|
Commenter does not have sufficient privileges for PR 3511 in repo Azure/ARO-RP |
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
This PR attempts to address the latest failure in the rpVMSS.sh script by adding retry logic to the yum update commands found therein. Failure can be observed in the ARO production pipeline e2e step.
What this PR does / why we need it:
Adds retry logic to yum update commands in rpVMSS.sh in order to allow for subsequent attempts if a resource lock is present,.
Test plan for issue: