Change the upgrademode of VMSS to rolling #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwnt
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
dofinn and
tiguelu
as code owners
hlipsig
approved these changes
Apr 12, 2024
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
cadenmarchese
approved these changes
Apr 12, 2024
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
approved these changes
Apr 16, 2024
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I deployed this PR to int, and the deployment succeeded. |
rajdeepc2792
approved these changes
Apr 17, 2024
SudoBrendan
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes: ARO-6610 (Upgrade Policy Mode part)
What this PR does / why we need it:
AzSecPack team policy requires that we don't use
Manualupgrade policy. Automatic shouldn't be used as it can introduce disruption and is not suitable for production workload. Changing this to rolling also means accepting the default values of the RollingUpgradePolicy, namely 20% maxBatchInstancePercent, maxUnhealthyInstancePercent, maxUnhealthyUpgradeInstancePercent and 0 pauseTimeBetweenBatches.Test plan for issue:
VMSSes (rp, gateway) can still be created and have upgradepolicy set to
rollingIs there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
VMSSes (rp, gateway) can still be created and have upgradepolicy set to
rolling