Automate Local Image Pruning #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SudoBrendan
requested changes
May 20, 2024
geowa4
reviewed
May 22, 2024
|
Please rebase pull request. |
safwank97
force-pushed
the
local-image-pruning-for-makeci-images
branch
from
6f5bb98
to
14e0b5f
Compare
safwank97
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
shubhadapaithankar
previously approved these changes
May 30, 2024
tsatam
previously approved these changes
May 30, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SudoBrendan
approved these changes
Jun 3, 2024
SudoBrendan
requested changes
Jun 3, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please rebase pull request. |
…moving --force flag in image pruning line
…parate PR and user story, thus rolling back the changes w.r.to to the builds to how they were written earlier
…the merge conflicts
safwank97
force-pushed
the
local-image-pruning-for-makeci-images
branch
from
acd60ed
to
546faa1
Compare
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SudoBrendan
approved these changes
Jun 6, 2024
tsatam
requested changes
Jun 6, 2024
tsatam
approved these changes
Jun 6, 2024
shubhadapaithankar
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-7189
What this PR does / why we need it:
This PR helps us automatically prune local container images generated by
make ci, so that we as developers do not run out of local disk space in our machines. Additionally it also does labeling for all the intermediate images in a multistage Docker file which could help us at the time of pruning.Test plan for issue:
Run
make ci-rpto producearo-*images and later runmake ci-cleanto verify and validate whether it is pruning those images to free up our local disk space.Is there any documentation that needs to be updated for this PR?
None that I'm aware of.