Add explicit ARG ARO_VERSION to RP build stage in ci-rp
#3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
anshulvermapatel
approved these changes
May 28, 2024
shubhadapaithankar
approved these changes
May 29, 2024
rajdeepc2792
approved these changes
Jun 3, 2024
SudoBrendan
approved these changes
Jun 3, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes no Jira
What this PR does / why we need it:
The
go-toolsetimage used to build the ARO binary inmake ci-rpsets its ownVERSIONenvironment variable, overriding theVERSIONarg we pass in. This results in theversion.GitCommitldflag being set to an incorrect value (version of Go in the go-toolset image).This PR changes the name of this argument to
ARO_VERSIONto avoid this naming conflict, and additionally explicitly sets this arg on the RP build stage, since all ARGs are set to nil at the completion of each stage in a multi-stage build.Test plan for issue:
make ci-rpwith this change in place, and ensured the resulting binary has the correct ldflags set forversion.GitCommit.Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
N/A (output of
make ci-rpnot yet used in production)