Removing the RP and Gateway SA creation functions #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azoppiserpa
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hlipsig
previously approved these changes
Jun 11, 2024
|
Would like a passing e2e before this merges. e2e currently broken we need to regenerate a certificate it uses. Working on getting it fixed. |
|
Please rebase pull request. |
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hlipsig
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-7792 and https://issues.redhat.com/browse/ARO-7791
What this PR does / why we need it:
Removes gateway and RP storage accounts that are used to store Boot Diagnostics logs, because we're now using Managed Boot Diagnostics and thus these two accounts are no longer necessary.
Previous PR making the Boot Diagnostics managed has already been merged: #3603
Test plan for issue:
Unit tests:
Ran
go testonpkg/deployand all passed.Ran
make generateand it generated the JSONs without the removed resources and parameters and no other undesired changes.Integration tests: not applicable.
Is there any documentation that needs to be updated for this PR?
If these two accounts are listed anywhere in our docs, we need to remove them from the list, as they will no longer exist, and explaining that our boot diagnostics is now of managed type. Are there any such documents? I can update them.
How do you know this will function as expected in production?
This is only removing resources, there isn't much to be verified I guess?