Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SDK to track2 in ensureGatewayCreate #3616

Merged
merged 2 commits into from
Sep 20, 2024
Merged

update SDK to track2 in ensureGatewayCreate #3616

merged 2 commits into from
Sep 20, 2024

Conversation

bitoku
Copy link
Collaborator

@bitoku bitoku commented Jun 6, 2024 •
edited
Loading

Which issue this PR addresses:

Fixes a part of https://issues.redhat.com/browse/ARO-4665 and https://issues.redhat.com/browse/ARO-7316

This is blocked until #3638 is released.

What this PR does / why we need it:

This PR makes ensureGateway action use track2 SDK.

Test plan for issue:

unittest for ensureGateway.
e2e

Is there any documentation that needs to be updated for this PR?

tech debt cleanup N/A

How do you know this will function as expected in production?

cluster installation test

@bitoku bitoku changed the title Ensure gateway create track2 update SDK to track2 in ensureGateway Jun 6, 2024
@bitoku bitoku changed the title update SDK to track2 in ensureGateway update SDK to track2 in ensureGatewayCreate Jun 6, 2024
@bitoku
Copy link
Collaborator Author

bitoku commented Jun 6, 2024

/azp run ci,e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Jun 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

Please rebase pull request.

@bitoku bitoku force-pushed the ensureGatewayCreate-track2 branch from 1037a78 to 6102c5d Compare June 7, 2024 11:02
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Jun 7, 2024
@bitoku
Copy link
Collaborator Author

bitoku commented Jun 7, 2024

/azp run ci,e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bitoku
Copy link
Collaborator Author

bitoku commented Jun 12, 2024

/azp run e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bitoku bitoku added the blocked Issue or pull request is blocked label Jun 12, 2024
@github-actions github-actions bot added the needs-rebase branch needs a rebase label Jun 17, 2024
@github-actions GitHub Actions
Copy link

Please rebase pull request.

@bitoku bitoku force-pushed the ensureGatewayCreate-track2 branch from 6102c5d to 23e0173 Compare July 3, 2024 15:53
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Jul 3, 2024
@bitoku bitoku marked this pull request as ready for review July 12, 2024 14:54
@bitoku bitoku added hold Hold and removed blocked Issue or pull request is blocked labels Jul 12, 2024
@bitoku bitoku force-pushed the ensureGatewayCreate-track2 branch from 23e0173 to a9c059d Compare July 12, 2024 15:00
@bitoku
Copy link
Collaborator Author

bitoku commented Jul 12, 2024

/azp run ci,e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bitoku bitoku removed the hold Hold label Jul 16, 2024
@bitoku
Copy link
Collaborator Author

bitoku commented Jul 16, 2024 •
edited
Loading

Waiting for #3638 to be released because it had a bug about tenant ID settings, and want to confirm it works first.

@bitoku bitoku mentioned this pull request Jul 16, 2024
Closed
@bitoku bitoku added blocked Issue or pull request is blocked hold Hold and removed blocked Issue or pull request is blocked labels Jul 16, 2024
mociarain
mociarain approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitoku bitoku removed the hold Hold label Aug 29, 2024
@bitoku
Copy link
Collaborator Author

bitoku commented Aug 29, 2024

/azp run ci,e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bitoku bitoku added the hold Hold label Aug 30, 2024
@bitoku bitoku removed the hold Hold label Sep 13, 2024
tiguelu
tiguelu approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@tiguelu tiguelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for updating these clients, Ayato.

I left some minor questions, but they can be tackled in a follow-up, if needed.

pkg/cluster/cluster.go Show resolved Hide resolved
pkg/cluster/cluster.go Show resolved Hide resolved
pkg/cluster/ipaddresses_test.go Show resolved Hide resolved
@tiguelu tiguelu merged commit b0518e7 into master Sep 20, 2024
21 checks passed
@tiguelu tiguelu deleted the ensureGatewayCreate-track2 branch September 20, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiguelu tiguelu tiguelu approved these changes

@mociarain mociarain mociarain approved these changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@SrinivasAtmakuri SrinivasAtmakuri Awaiting requested review from SrinivasAtmakuri SrinivasAtmakuri is a code owner

@AldoFusterTurpin AldoFusterTurpin Awaiting requested review from AldoFusterTurpin

@kimorris27 kimorris27 Awaiting requested review from kimorris27 kimorris27 is a code owner

@tsatam tsatam Awaiting requested review from tsatam tsatam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitoku @tiguelu @mociarain