Use latest "in-progress" ARO API for local/E2E cluster creation #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
force-pushed
the
tsatam/ARO-8003-use-in-progress-api-for-cluster-creation
branch
from
fd8b39b
to
f4cce74
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci,e2e |
|
Please rebase pull request. |
tsatam
force-pushed
the
tsatam/ARO-8003-use-in-progress-api-for-cluster-creation
branch
from
f4cce74
to
abcb2eb
Compare
tsatam
force-pushed
the
tsatam/ARO-8003-use-in-progress-api-for-cluster-creation
branch
from
abcb2eb
to
c05f300
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
tsatam
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain and
AldoFusterTurpin
as code owners
|
Please rebase pull request. |
tsatam
force-pushed
the
tsatam/ARO-8003-use-in-progress-api-for-cluster-creation
branch
from
c05f300
to
510b3ee
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
tsatam
commented
Jul 24, 2024
mociarain
previously approved these changes
Jul 25, 2024
tsatam
force-pushed
the
tsatam/ARO-8003-use-in-progress-api-for-cluster-creation
branch
from
e153071
to
510b3ee
Compare
mociarain
approved these changes
Jul 25, 2024
SudoBrendan
approved these changes
Jul 26, 2024
mociarain
deleted the
tsatam/ARO-8003-use-in-progress-api-for-cluster-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-8003
What this PR does / why we need it:
This PR updates
pkg/util/cluster/cluster.goto use the latest in-progress API (v20240812preview) when environment variableRP_MODEis set todevelopment, and the latest released API that's routable in ARM otherwise (v20231122).This allows local development cluster creation, as well as E2E runs against a locally running RP (e.g. the E2E PR pipeline) to test cluster creation/deletion against our in-progress API, while still ensuring that we utilize the latest ARM-routable API during production contexts (e.g. prod E2E).
The implementation here is generic, and could be expanded in the future to allow us to arbitrarily select which ARO API version we would like to use.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?
This change is not utilized by any production services, and is only utilized in development and E2E flows.