[ARO-4562] Migrate DNS to track2 SDK, arm dns client creation. #3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan34c
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Closed
bitoku
reviewed
Jun 24, 2024
bitoku
approved these changes
Jun 25, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cadenmarchese
approved these changes
Jun 26, 2024
|
e2e is currently broken, but I'm comfortable merging this without as this is just adding a new client and vendoring in a new package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes
What this PR does / why we need it:
Replace original dns with newly createdDNS using track2 SDK
Originally created a PR to replace the DNS, but the scope was too large. Therefore, I split the last PR to small pieces. this was the creating of the new armdns client. More PR will follow once this PR is merged.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?