-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror two Microsoft Geneva images #3635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update int like RP deployment with a step on mirroring two distroless Microsoft Geneva images to your ACR
razo7
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
June 17, 2024 15:01
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Following past erros on mirroring images, add workaroung steps on how to install missing packages or simply ignore them while ./cmd/aro mirror
razo7
force-pushed
the
fetch-geneva-anonymously
branch
from
June 18, 2024 06:29
7deea16
to
090922c
Compare
Simplify two notes to one troubleshooting line
razo7
force-pushed
the
fetch-geneva-anonymously
branch
from
June 18, 2024 06:39
f41350d
to
0ef0c3c
Compare
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Export variable and run one liner for az acr import
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
tiguelu
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
devmapper
andbtrfs
packages or ignoring them while mirroring images using Golang due to the following error:What this PR does / why we need it:
Fix two issues when following https://github.com/Azure/ARO-RP/blob/master/docs/deploy-full-rp-service-in-dev.md tutorial on a fresh new RHEL 8.10.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
Yes - https://github.com/Azure/ARO-RP/blob/master/docs/deploy-full-rp-service-in-dev.md
How do you know this will function as expected in production?
I have followed https://github.com/Azure/ARO-RP/blob/master/docs/deploy-full-rp-service-in-dev.md and I have noticed the problematic behavior. After looking at past conversations on the team's Slack channel, I am suggesting on ways to overcome the above two issues.