Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror two Microsoft Geneva images #3635

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Mirror two Microsoft Geneva images #3635

merged 5 commits into from
Jun 28, 2024

Conversation

razo7
Copy link
Collaborator

@razo7 razo7 commented Jun 17, 2024

Which issue this PR addresses:

  1. Update int like RP deployment with a step on mirroring two distroless Microsoft Geneva images to your ACR. Follow up to ARO-7837 & Update coordinates for MDM/MDSD images openshift/installer-aro-wrapper#122 due to the following error:
... MDMIMAGE=razoaro.azurecr.io/distroless/genevamdm:2.2024.517.533-b73893-20240522t0954@sha256:939df9d7b6660874697f8ebed1fe56504f86d92f99801a9dc6fd98e9176d3f75\\n++ docker pull razoaro.azurecr.io/distroless/genevamdm:2.2024.517.533-b73893-20240522t0954@sha256:939df9d7b6660874697f8ebed1fe56504f86d92f99801a9dc6fd98e9176d3f75\\nTrying to pull razoaro.azurecr.io/distroless/genevamdm@sha256:939df9d7b6660874697f8ebed1fe56504f86d92f99801a9dc6fd98e9176d3f75...\\nError: initializing source docker://razoaro.azurecr.io/distroless/genevamdm@sha256:939df9d7b6660874697f8ebed1fe56504f86d92f99801a9dc6fd98e9176d3f75: reading manifest sha256:939df9d7b6660874697f8ebed1fe56504f86d92f99801a9dc6fd98e9176d3f75 in razoaro.azurecr.io/distroless/genevamdm: manifest unknown: manifest sha256:939df9d7b6660874697f8ebed1fe56504f86d92f99801a9dc6fd98e9176d3f75 is not found\\n'. More information on troubleshooting is available at https://aka.ms/VMExtensionCSELinuxTroubleshoot. \"\r\n      }\r\n    ]\r\n  }\r\n}"}] 
FATA[2024-06-17T12:12:00+03:00]cmd/aro/main.go:80 main.main() an error occurred                            
exit status 1
make: *** [Makefile:102: deploy] Error 1
  1. Add two workarounds for installing devmapper and btrfs packages or ignoring them while mirroring images using Golang due to the following error:
➜  ARO-RP git:(master) ✗ go run ./cmd/aro mirror latest
go build github.com/containers/storage/pkg/devicemapper:
# pkg-config --cflags  -- devmapper
Package devmapper was not found in the pkg-config search path.
Perhaps you should add the directory containing `devmapper.pc'
to the PKG_CONFIG_PATH environment variable
Package 'devmapper', required by 'virtual:world', not found
pkg-config: exit status 1
# github.com/containers/storage/drivers/btrfs
vendor/github.com/containers/storage/drivers/btrfs/btrfs.go:12:10: fatal error: btrfs/ioctl.h: No such file or directory
 #include <btrfs/ioctl.h>
          ^~~~~~~~~~~~~~~
compilation terminated.

What this PR does / why we need it:

Fix two issues when following https://github.com/Azure/ARO-RP/blob/master/docs/deploy-full-rp-service-in-dev.md tutorial on a fresh new RHEL 8.10.

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

Yes - https://github.com/Azure/ARO-RP/blob/master/docs/deploy-full-rp-service-in-dev.md

How do you know this will function as expected in production?

I have followed https://github.com/Azure/ARO-RP/blob/master/docs/deploy-full-rp-service-in-dev.md and I have noticed the problematic behavior. After looking at past conversations on the team's Slack channel, I am suggesting on ways to overcome the above two issues.

Update int like RP deployment with a step on mirroring two distroless Microsoft Geneva images to your ACR
@razo7
Copy link
Collaborator Author

razo7 commented Jun 18, 2024

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Following past erros on mirroring images, add workaroung steps on how to install missing packages or simply ignore them while ./cmd/aro mirror
Simplify two notes to one troubleshooting line
@razo7
Copy link
Collaborator Author

razo7 commented Jun 18, 2024

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Export variable and run one liner for az acr import
@razo7
Copy link
Collaborator Author

razo7 commented Jun 18, 2024

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@tiguelu tiguelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiguelu
Copy link
Contributor

tiguelu commented Jun 28, 2024

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tiguelu tiguelu merged commit ae26d76 into master Jun 28, 2024
20 checks passed
@tiguelu tiguelu deleted the fetch-geneva-anonymously branch June 28, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants