Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARO-9169] Remove disused clustermanager frontend code #3642

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[ARO-9169] Remove disused clustermanager frontend code #3642

merged 1 commit into from
Jul 16, 2024

Conversation

hawkowl
Copy link
Collaborator

@hawkowl hawkowl commented Jun 24, 2024 •
edited
Loading

Fixes https://issues.redhat.com/browse/ARO-9169

Removes the ClusterManager frontend code that is non-functional and won't be switched on.

@hawkowl
Copy link
Collaborator Author

hawkowl commented Jun 24, 2024

/azp run ci, e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hawkowl hawkowl force-pushed the hawkowl/remove-clustermanager branch from 9ae4dc4 to 2272ec6 Compare June 25, 2024 03:34
@hawkowl
Copy link
Collaborator Author

hawkowl commented Jun 25, 2024

/azp run ci, classic-pr-e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hawkowl
Copy link
Collaborator Author

hawkowl commented Jun 25, 2024

/azp run e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mociarain
Copy link
Collaborator

Can you give some guidance on how to review this? I'm not super sure how to test this or what removing all this code means. If there's any supporting docs or anything I'd appreciate a link :)

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Jul 15, 2024
@github-actions GitHub Actions
Copy link

Please rebase pull request.

@hawkowl hawkowl force-pushed the hawkowl/remove-clustermanager branch from 2272ec6 to 11ebd08 Compare July 16, 2024 01:54
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Jul 16, 2024
@hawkowl hawkowl changed the title Remove disused clustermanager frontend code [ARO-9169] Remove disused clustermanager frontend code Jul 16, 2024
@hawkowl hawkowl force-pushed the hawkowl/remove-clustermanager branch from 11ebd08 to e4a2223 Compare July 16, 2024 02:18
@hawkowl
Copy link
Collaborator Author

hawkowl commented Jul 16, 2024

/azp run ci, e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hawkowl hawkowl added size-small Size small ready-for-review go Pull requests that update Go code skippy pull requests raised by member of Team Skippy labels Jul 16, 2024
kimorris27
kimorris27 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@kimorris27 kimorris27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mociarain , my understanding is that this code is related to some API endpoints for functionality that never ended up being used. And because Azure API docs are generated from code, these unused APIs are documented publicly... so every once in a while, we get an alert where a customer is trying to do something with one of these unsupported endpoints. It looks like this is the first in a series of PRs that will remove all of this cluster manager stuff.

The Jira epic description supports my understanding, which is why I'm comfortable approving.

@hawkowl hawkowl merged commit 94cd8d7 into master Jul 16, 2024
21 checks passed
@hawkowl hawkowl deleted the hawkowl/remove-clustermanager branch July 16, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimorris27 kimorris27 kimorris27 approved these changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@tiguelu tiguelu Awaiting requested review from tiguelu tiguelu is a code owner

@SrinivasAtmakuri SrinivasAtmakuri Awaiting requested review from SrinivasAtmakuri SrinivasAtmakuri is a code owner

@mociarain mociarain Awaiting requested review from mociarain mociarain is a code owner

@AldoFusterTurpin AldoFusterTurpin Awaiting requested review from AldoFusterTurpin

@tsatam tsatam Awaiting requested review from tsatam tsatam is a code owner

Assignees
No one assigned
Labels
go Pull requests that update Go code ready-for-review size-small Size small skippy pull requests raised by member of Team Skippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkowl @mociarain @kimorris27