Preflight update and tests #3686
Merged
+402
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carvalhe
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
AldoFusterTurpin,
kimorris27 and
tsatam
as code owners
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
SudoBrendan
approved these changes
Jul 16, 2024
Comment on lines
+85
to
+95
| `, apiVersion, clusterId, api.ExampleOpenShiftClusterDocument().OpenShiftCluster.Name, | ||
| api.ExampleOpenShiftClusterDocument().OpenShiftCluster.Type, | ||
| location, defaultProfile, resourceGroup, api.EncryptionAtHostEnabled, version.DefaultInstallStream.Version.String(), | ||
| mockSubID, mockSubID, netProfile, netProfile, api.VMSizeStandardD32sV3, masterSub, | ||
| api.EncryptionAtHostEnabled, encryptionSet, | ||
| api.ExampleOpenShiftClusterDocument().OpenShiftCluster.Properties.WorkerProfiles[0].Name, api.VMSizeStandardD32sV3, | ||
| api.ExampleOpenShiftClusterDocument().OpenShiftCluster.Properties.WorkerProfiles[0].DiskSizeGB, | ||
| api.EncryptionAtHostEnabled, workerSub, | ||
| api.ExampleOpenShiftClusterDocument().OpenShiftCluster.Properties.WorkerProfiles[0].Count, | ||
| encryptionSet, api.VisibilityPublic, defaultProfile, api.VisibilityPublic, | ||
| api.ExampleOpenShiftClusterDocument().OpenShiftCluster.Properties.IngressProfiles[0].IP)) |
There was a problem hiding this comment.
nit: 28 ordered parameters is going to be hard to maintain over time - if it's easy enough, can we convert this to a golang string template, and then populate it with named parameters rather than ordered ones?
| Resources: []json.RawMessage{ | ||
| []byte(fmt.Sprintf(` | ||
| { | ||
| "apiVersion": "%s", |
There was a problem hiding this comment.
nit: same as above - now thinking this should be wrapped in a function call, where you pass it a map of variables.
|
Merging with approvals for now, but @carvalhe let's try and get Brendan's ideas in a separate PR if possible. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-3854
What this PR does / why we need it:
Currently we have preflight set up for create operations but also need it for update. These changes allow for both put/patch operations on preflight. This PR also cleans up the way we validate for preflight and adds new checks for it as well. There was a previous PR for this here: #3365 but it was getting messy, and needed to move off the forked branch so that E2E tests would work correctly.
Test plan for issue:
Created additional unit tests that are similar to put/patch tests. Kusto logs also show preflight success and failures with more details than before. Preflight is also marked for testing and won't hit live until another PR in the future sets that value.