Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics/GenevaActions for Clustersync #3785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhamitarora
Copy link
Collaborator

@rhamitarora rhamitarora commented Aug 21, 2024

Which issue this PR addresses:

ARO-9545 and ARO-8659 both JIRA's have common code

What this PR does / why we need it:

  1. Create new clustersync metrics under monitor package. Both syncSets and selectorSyncSets should be merged into the same Geneva metric.
  2. Create a Geneva Action to show the clustersync resource of a cluster.

Test plan for issue:

Unit test cases added.
Need to create respective metrics dashboard in Geneva.

Is there any documentation that needs to be updated for this PR?

Will create TSGs for respective metrics.

How do you know this will function as expected in production?

Monitor from Geneva Dashboard.

@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch 5 times, most recently from 3cdbf8c to 8d1a6e9 Compare August 27, 2024 11:30
@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch 6 times, most recently from b5ac73b to 99fa8df Compare September 11, 2024 07:40
@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch 18 times, most recently from 08835f8 to 41a6e7c Compare September 17, 2024 12:43
@rhamitarora rhamitarora marked this pull request as ready for review September 17, 2024 14:16
@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch 3 times, most recently from 9fd3845 to 92f6239 Compare September 25, 2024 05:46
@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch from 92f6239 to 44fb657 Compare September 25, 2024 16:14
@github-actions github-actions bot added needs-rebase branch needs a rebase and removed ready-for-review labels Sep 26, 2024
Copy link

Please rebase pull request.

@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch from 44fb657 to dbe2252 Compare September 30, 2024 04:55
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Sep 30, 2024
@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch 5 times, most recently from 0d490bc to d58121a Compare September 30, 2024 06:04
@SrinivasAtmakuri SrinivasAtmakuri changed the title Metrics for SyncSet and SelectorSyncSets Metrics/GenevaActions for Clustersync Oct 1, 2024
@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch from d58121a to 07bb5a7 Compare October 4, 2024 04:34
@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch from 07bb5a7 to 931666c Compare October 8, 2024 06:37
@github-actions github-actions bot added the needs-rebase branch needs a rebase label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Please rebase pull request.

@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch from 931666c to 7b5b32e Compare October 10, 2024 05:44
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Oct 10, 2024
@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch from 7b5b32e to 73a735a Compare October 10, 2024 05:57
merging 8659 and 9545

Metrics for SyncSet and SelectorSyncSets
@rhamitarora rhamitarora force-pushed the rhamitarora/ARO-9545-syncset-metrics branch from 73a735a to 0cacc86 Compare October 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firefly Issues or Pull requests owned by Team Firefly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants