-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics/GenevaActions for Clustersync #3785
Open
rhamitarora
wants to merge
1
commit into
master
Choose a base branch
from
rhamitarora/ARO-9545-syncset-metrics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
5 times, most recently
from
August 27, 2024 11:30
3cdbf8c
to
8d1a6e9
Compare
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
6 times, most recently
from
September 11, 2024 07:40
b5ac73b
to
99fa8df
Compare
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
18 times, most recently
from
September 17, 2024 12:43
08835f8
to
41a6e7c
Compare
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
3 times, most recently
from
September 25, 2024 05:46
9fd3845
to
92f6239
Compare
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
from
September 25, 2024 16:14
92f6239
to
44fb657
Compare
github-actions
bot
added
needs-rebase
branch needs a rebase
and removed
ready-for-review
labels
Sep 26, 2024
Please rebase pull request. |
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
from
September 30, 2024 04:55
44fb657
to
dbe2252
Compare
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
5 times, most recently
from
September 30, 2024 06:04
0d490bc
to
d58121a
Compare
SrinivasAtmakuri
changed the title
Metrics for SyncSet and SelectorSyncSets
Metrics/GenevaActions for Clustersync
Oct 1, 2024
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
from
October 4, 2024 04:34
d58121a
to
07bb5a7
Compare
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
from
October 8, 2024 06:37
07bb5a7
to
931666c
Compare
Please rebase pull request. |
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
from
October 10, 2024 05:44
931666c
to
7b5b32e
Compare
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
from
October 10, 2024 05:57
7b5b32e
to
73a735a
Compare
merging 8659 and 9545 Metrics for SyncSet and SelectorSyncSets
rhamitarora
force-pushed
the
rhamitarora/ARO-9545-syncset-metrics
branch
from
October 10, 2024 09:50
73a735a
to
0cacc86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
ARO-9545 and ARO-8659 both JIRA's have common code
What this PR does / why we need it:
Test plan for issue:
Unit test cases added.
Need to create respective metrics dashboard in Geneva.
Is there any documentation that needs to be updated for this PR?
Will create TSGs for respective metrics.
How do you know this will function as expected in production?
Monitor from Geneva Dashboard.