Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow refresh_cluster_credentials with platowrm_workload_identities #3870

Merged
merged 6 commits into from
Oct 9, 2024
Merged

disallow refresh_cluster_credentials with platowrm_workload_identities #3870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
459d6b7
disallow refresh_cluster_credentials with platowrm_workload_identities
slawande2 Sep 27, 2024
53907d3
add pylint comment
slawande2 Sep 30, 2024
e9aaeb3
fix python lint issue
slawande2 Oct 1, 2024
d17feb4
fix pylint issue
slawande2 Oct 2, 2024
6593f24
Revert "disallow refresh_cluster_credentials with platform_workload_i…
slawande2 Oct 7, 2024
f6eeb3b
disallow refresh_cluster_credentials with platform_workload_identitie…
slawande2 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/az/aro/azext_aro/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,8 @@ def validate_refresh_cluster_credentials(namespace):
return
if namespace.client_secret is not None or namespace.client_id is not None:
raise RequiredArgumentMissingError('--client-id and --client-secret must be not set with --refresh-credentials.') # pylint: disable=line-too-long
if namespace.platform_workload_identities is not None:
raise MutuallyExclusiveArgumentError('--platform-workload-identities must be not set with --refresh-credentials.') # pylint: disable=line-too-long
if namespace.upgradeable_to is not None:
raise MutuallyExclusiveArgumentError('Must not specify --refresh-credentials when --upgradeable-to is used.') # pylint: disable=line-too-long

Expand Down
7 changes: 6 additions & 1 deletion python/az/aro/azext_aro/tests/latest/unit/test_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,9 +815,14 @@ def test_validate_worker_vm_disk_size_gb(test_description, namespace, expected_e
Mock(client_id="client_id_456"),
RequiredArgumentMissingError
),
(
"should raise MutuallyExclusiveArgumentError Exception because namespace.platform_workload_identities is present",
Mock(platform_workload_identities=[Mock(resource_id='Foo')], client_id=None, client_secret=None),
MutuallyExclusiveArgumentError
),
(
"should not raise any Exception because namespace.client_secret is None and namespace.client_id is None",
Mock(upgradeable_to=None, client_secret=None, client_id=None),
Mock(upgradeable_to=None, client_secret=None, client_id=None, platform_workload_identities=None),
None
),
(
Expand Down
Loading