Selenium Service Migration to Docker Compose #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhadapaithankar
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-10902-selenium-service
branch
from
86205d3
to
4a00be0
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci |
slawande2
previously approved these changes
Oct 10, 2024
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-10902-selenium-service
branch
from
af8ebd4
to
cb56540
Compare
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-10902-selenium-service
branch
from
cb56540
to
b13fec1
Compare
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-10902-selenium-service
branch
from
b13fec1
to
e839eb0
Compare
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
slawande2
previously approved these changes
Oct 10, 2024
tsatam
previously approved these changes
Oct 10, 2024
…h the original configuration
shubhadapaithankar
dismissed stale reviews from tsatam and slawande2
via
c6f0f93
tsatam
approved these changes
Oct 10, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
slawande2
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes: ARO-10902
What this PR does / why we need it:
This PR migrates the Selenium service to Docker Compose, ensuring it runs in an isolated container with proper health checks. It simplifies the process of running Selenium for automated browser testing as part of the CI/CD pipeline. This also improves the maintainability of the infrastructure by consolidating service management into Docker Compose.
Test plan for issue:
This PR was tested by running the Docker Compose setup locally to validate the Selenium service operates correctly and responds on
localhost:4444.Health checks are configured to ensure proper functionality. Additionally, integration tests were executed to verify that Selenium can interact with the system as expected.Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?