SDK2: Remove old SDK from Dynamic/ValidateQuota #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitoku
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam and
fahlmant
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
approved these changes
Oct 8, 2024
dkeohane
reviewed
Oct 11, 2024
| @@ -160,13 +160,16 @@ func (dv *openShiftClusterDynamicValidator) Dynamic(ctx context.Context) error { | |||
| spClientCred, | |||
| pdpClient, | |||
| ) | |||
| if err != nil { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-4665
What this PR does / why we need it:
This PR replaces the old SDK to the new SDK2.
It affects Dynamic pkg (used in validateResources step) and ValidateQuota.go (used in openshiftcluster_putorpatch.go).
Test plan for issue:
e2e, ci
e2e creates a cluster, which verifies the validateResource step and ValidateQuota.
Is there any documentation that needs to be updated for this PR?
na
How do you know this will function as expected in production?
Cluster creation will verify the change