Fix bug in hive-dev-install.sh #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hack/util.sh: line 14: would: unbound variable occurs in it's current state.
s-fairchild
added
bug
s-fairchild
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
approved these changes
Oct 9, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hack/util.sh: line 14: would: unbound variable occurs in it's current state.
Which issue this PR addresses:
Fixes ARO-11090
What this PR does / why we need it:
I have removed the erroneous
-ncausing the log message to be read as a variable.-nis being passed as a the first argument to log, which then causes themsgstring to be used for argument two, stack_level. Since argument two expects a variable, it then fails with an unbound variable error.Example of the error in it's current state.
./hack/hive/hive-dev-install.sh main: enter hive installation main: hive is already installed in namespace hive hack/util.sh: line 14: would: unbound variableTest plan for issue:
I've tested this script locally with my changes to ensure it functions correctly.
Is there any documentation that needs to be updated for this PR?
No.
How do you know this will function as expected in production?
Locally testing showed removing this allows the script to function.