feat: add artifact upload for coverage e2e #3120
Conversation
UtheMan
requested review from
alexeldeib,
juan-lee,
AbelHu and
thomas1206
as code owners
Pull Request Test Coverage Report for Build 4820296174
💛 - Coveralls |
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: scenario-logs | ||
| path: e2e/scenario-logs |
There was a problem hiding this comment.
something I was meaning to do on the ADO side - can we upload a new bundle that doesn't include scenario-logs/*/vmssId.txt? those text files are only there such that we can ensure the ephemeral VMSS's are deleted (we have an 'ensure vmss deletion' step in the ADO pipeline that reads the ids from those text files and does 'az delete --ids ...' on them).
I'm also realizing now that we don't have the same sort of 'ensure vmss deletion' step on the GH action side...
we should really choose ADO/GH and pivot towards that
There was a problem hiding this comment.
might also be worth leaving those text files lying around so we can use them to manually delete stuff via az cli if needed since we don't have that 'ensure vmss deletion' step on this side...
I'll leave it up to you
There was a problem hiding this comment.
(can also just go use the portal to delete... :D)
There was a problem hiding this comment.
I will be looking into how i could combine ADO running e2e and gh action taking results of that and handling everything else
What type of PR is this?
What this PR does / why we need it:
Ensures no regression for #2815
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: