refactor(stls): augment secure TLS bootstrapping configuration options in NodeBootstrappingConfiguration/AKSNodeConfig #7112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in NodeBootstrappingConfiguration/AKSNodeConfig
…eissner/stls/config-cleanup
cameronmeissner
changed the title
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
cameronmeissner
requested review from
AbelHu,
Devinwong,
anujmaheshwari1,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
r2k1 and
timmy-wright
as code owners
cameronmeissner
requested review from
bravebeaver,
phealy and
zachary-bailey
as code owners
Devinwong
reviewed
Oct 9, 2025
Devinwong
reviewed
Oct 9, 2025
r2k1
reviewed
Oct 9, 2025
zachary-bailey
approved these changes
Oct 9, 2025
Devinwong
approved these changes
Oct 9, 2025
awesomenix
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind refactor
What this PR does / why we need it:
We need to respect all the different custom configuration operations that are exposed by the secure TLS bootstrap client. This PR introduces support for properly customizing the AAD resource, user assigned identity ID, as well as the bootstrapping deadline that are all passed to the secure TLS bootstrap client when secure TLS bootstrapping is enabled.
This PR also cleans up out-dated fields and introduces some renaming, while aligning NodeBootstrappingConfiguration + AKSNodeConfig accordingly
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: