fix: strip unnecessary files from Flatcar's Ignition data to save space #7184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewi
requested review from
AbelHu,
Devinwong,
anujmaheshwari1,
bravebeaver,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
jepio
approved these changes
Oct 13, 2025
5 tasks
chewi
force-pushed
the
chewi/flatcar-ignition-size
branch
from
de75ff4 to
5f3a3a7
Compare
Contributor
Author
|
FYI CI has already passed once, but I've had to rebase it due to a conflict in the test data. |
cameronmeissner
approved these changes
Oct 13, 2025
Member
|
@chewi this will need another rebase, sorry. i'll be able to reapprove tomorrow morning! |
Contributor
Author
Actually, I think you got away with it. Your change didn't touch the Flatcar file. The other files only had a single whitespace change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
The amount of data we can provision Azure VMs with is limited. Recent changes have pushed Flatcar's Ignition data over that limit. It has been including unnecessary files, such as those only used by Ubuntu, so this strips those out, bringing it under the limit again.
Requirements:
Special notes for your reviewer:
I had included this in #7125, but we now need the fix merged more urgently, as it is breaking E2E is current master.
Release note:
N/A