Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowedValues alignment #1702

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

allowedValues alignment #1702

wants to merge 7 commits into from

Conversation

Brunoga-MS
Copy link
Contributor

@Brunoga-MS Brunoga-MS commented Jul 4, 2024

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Aligns the setting of allowedValues in the initiative with those expected by the policyDefinition
  2. Updated what's new documentation with changes covered in this PR

Breaking Changes

  1. NONE

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

[Deploy To Azure](https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Feslz-portal.json)

Azure US Gov (Fairfax)

[Deploy To Azure](https://portal.azure.us/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Ffairfaxeslz-portal.json)

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Brunoga-MS Brunoga-MS requested a review from a team as a code owner July 4, 2024 14:12
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brunoga-MS looks great, some minor changes please.
Please increment minor versions of the initiatives, and provide a whats new update :)

@Springstone Springstone added Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments labels Jul 10, 2024
@Brunoga-MS
Copy link
Contributor Author

@Springstone done :)

@Springstone Springstone added this to the policy-refresh-fy25-q1 milestone Jul 11, 2024
@Springstone Springstone self-requested a review July 11, 2024 14:11
Springstone
Springstone previously approved these changes Jul 11, 2024
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jtracey93 for final review and merge.

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Springstone and @Brunoga-MS

A couple of comments and one question below:

  1. Why the casing changes/additions for audit where Audit already exists?

docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
accepted suggestion

Co-authored-by: Jack Tracey <[email protected]>
accepted suggestion

Co-authored-by: Jack Tracey <[email protected]>
@Brunoga-MS
Copy link
Contributor Author

Thanks @Springstone and @Brunoga-MS

A couple of comments and one question below:

  1. Why the casing changes/additions for audit where Audit already exists?

@jtracey93 ,
casing changes/additions were applied just because the original policy definitions were including them and I was told to ensure definitions and initiatives had the same allowed values :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy Set, Enforce-Guardrails-Network Bug Report
3 participants