Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proxy_agent/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ tower-http = { version = "0.6.2", features = ["limit"] }
clap = { version = "4.5.17", features =["derive"] } # Command Line Argument Parser
thiserror = "1.0.64"
libc = "0.2.147"
socket2 = "0.5" # Set socket options without tokio/std conversion

[dependencies.uuid]
version = "1.3.0"
Expand Down
56 changes: 15 additions & 41 deletions proxy_agent/src/proxy/proxy_server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -253,24 +253,20 @@ impl ProxyServer {
tokio::spawn({
let cloned_proxy_server = self.clone();
async move {
let (stream, _cloned_std_stream) =
match Self::set_stream_read_time_out(stream, &mut tcp_connection_logger) {
Ok((stream, cloned_std_stream)) => (stream, cloned_std_stream),
Err(e) => {
tcp_connection_logger.write(
LoggerLevel::Error,
format!("Failed to set stream read timeout: {e}"),
);
return;
}
};
// Get raw socket ID before any conversion (Windows only)
#[cfg(windows)]
let raw_socket_id = Self::get_stream_raw_socket_id(&stream);

// Set read timeout directly on the socket without conversion
Self::set_stream_read_time_out(&stream, &mut tcp_connection_logger);

let tcp_connection_context = TcpConnectionContext::new(
tcp_connection_id,
client_addr,
cloned_proxy_server.redirector_shared_state.clone(),
cloned_proxy_server.proxy_server_shared_state.clone(),
#[cfg(windows)]
ProxyServer::get_stream_rocket_id(&_cloned_std_stream),
raw_socket_id,
)
.await;

Expand Down Expand Up @@ -324,46 +320,24 @@ impl ProxyServer {
}

#[cfg(windows)]
fn get_stream_rocket_id(stream: &std::net::TcpStream) -> usize {
fn get_stream_raw_socket_id(stream: &TcpStream) -> usize {
use std::os::windows::io::AsRawSocket;
stream.as_raw_socket() as usize
}

// Set the read timeout for the stream
fn set_stream_read_time_out(
stream: TcpStream,
connection_logger: &mut ConnectionLogger,
) -> Result<(TcpStream, std::net::TcpStream)> {
// Convert the stream to a std stream
let std_stream = stream.into_std().map_err(|e| {
Error::Io(
"Failed to convert Tokio stream into std equivalent".to_string(),
e,
)
})?;
// Uses socket2::SockRef to set socket options directly on the tokio stream
// socket2 crate already used by tokio internally, so it won't cause extra dependency
fn set_stream_read_time_out(stream: &TcpStream, connection_logger: &mut ConnectionLogger) {
use socket2::SockRef;

// Set the read timeout
if let Err(e) = std_stream.set_read_timeout(Some(std::time::Duration::from_secs(10))) {
let sock_ref = SockRef::from(stream);
if let Err(e) = sock_ref.set_read_timeout(Some(std::time::Duration::from_secs(10))) {
connection_logger.write(
LoggerLevel::Warn,
format!("Failed to set read timeout: {e}"),
);
}

// Clone the stream for the service_fn
let cloned_std_stream = std_stream
.try_clone()
.map_err(|e| Error::Io("Failed to clone TCP stream".to_string(), e))?;

// Convert the std stream back
let tokio_tcp_stream = TcpStream::from_std(std_stream).map_err(|e| {
Error::Io(
"Failed to convert std stream into Tokio equivalent".to_string(),
e,
)
})?;

Ok((tokio_tcp_stream, cloned_std_stream))
}

async fn handle_new_http_request(
Expand Down
Loading