Skip to content

Add elapsed time to command execution spinner #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+410 −1
Open

Add elapsed time to command execution spinner #261

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
facf2b0
Initial plan for issue
Copilot May 20, 2025
1100ba1
Add elapsed time to command execution spinner
Copilot May 20, 2025
8e91b3d
Add spinner test with elapsed time display
Copilot May 20, 2025
d011af0
Create streaming test to display spinner with elapsed time
Copilot May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/engine/execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ func (e *Engine) ExecuteAndRenderSteps(steps []common.Step, env map[string]strin

var commandErr error
var frame int = 0
startTime := time.Now() // Record the start time for progress indicator

// If forwarding input/output, don't render the spinner.
if !interactiveCommand {
Expand Down Expand Up @@ -246,7 +247,10 @@ func (e *Engine) ExecuteAndRenderSteps(steps []common.Step, env map[string]strin
break renderingLoop
default:
frame = (frame + 1) % len(spinnerFrames)
fmt.Printf("\r %s", ui.SpinnerStyle.Render(string(spinnerFrames[frame])))
elapsedTime := time.Since(startTime)
minutes := int(elapsedTime.Minutes())
seconds := int(elapsedTime.Seconds()) % 60
fmt.Printf("\r %s [%02d:%02d elapsed]", ui.SpinnerStyle.Render(string(spinnerFrames[frame])), minutes, seconds)
time.Sleep(spinnerRefresh)
}
}
Expand Down