Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Adding New Generic HTTP Target #446

Merged
merged 15 commits into from
Oct 15, 2024
Merged

FEAT: Adding New Generic HTTP Target #446

merged 15 commits into from
Oct 15, 2024

Conversation

jbolor21
Copy link
Contributor

@jbolor21 jbolor21 commented Oct 9, 2024 •
edited
Loading

Description

Adding a new target for endpoints without APIs (like Bing Image Creator).

This is updated from three closed PRs:

#350
#351
#392

Also to make this work the SearchReplaceConverter was altered to use regex rather than .replace(). This allows for more flexibility in replacing characters/strings.

Tests and Documentation

Added notebook to test AOAI and BIC endpoints using HTTP Target and added unit tests

nina-msft
nina-msft approved these changes Oct 9, 2024
View reviewed changes
doc/code/targets/http_target.py Outdated Show resolved Hide resolved
@jbolor21 jbolor21 merged commit fe72c67 into Azure:main Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlundeen2 rlundeen2 rlundeen2 left review comments

@nina-msft nina-msft nina-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbolor21 @rlundeen2 @nina-msft