adding example policies for tpm and circuit breaker #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkerkhove
reviewed
Jan 12, 2024
examples/circuitbreaker.xml
Outdated
| @@ -0,0 +1,41 @@ | |||
| <policies> | |||
There was a problem hiding this comment.
I think we can remove this, circuit breaker is built-in nowadays - https://learn.microsoft.com/en-us/azure/api-management/backends?tabs=bicep#circuit-breaker-preview
There was a problem hiding this comment.
removed the file, and updated the readme as well.
tomkerkhove
reviewed
Sep 9, 2024
| <base /> | ||
| <!--Priority Management Based on Subscription Keys: | ||
| Applies quotas based on the subscription key. --> | ||
| <choose> |
There was a problem hiding this comment.
Any particular reason why we don't use set-variable to define the allowed calls and then only define rate-limit-by-key once?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding policies for