Skip to content

Removes issue where we don't push initial blob, moves to better sync.Pool, metrics are on newer format#34

Merged
element-of-surprise merged 3 commits into
mainfrom
fixDuplication
Sep 23, 2025
Merged

Removes issue where we don't push initial blob, moves to better sync.Pool, metrics are on newer format#34
element-of-surprise merged 3 commits into
mainfrom
fixDuplication

Conversation

@element-of-surprise
Copy link
Copy Markdown
Member

Found an issue where we would duplicate sends.

  • Added test to address issue

Using sync.Pool, went to gostdlib typed version

  • Cleaner and safer

Metrics on new format

  • Kinda, all the metrics now with arn_sdk instead of unsupported arn-sdk now remove quotes using new format
  • Weirdly, "target" which is autogenerated stays in the old one unless we go to 1.60 and use a special option, so that stays
  • New stuff emits _count and _total automatically for certain metric types, so I had to deduplicate it
  • This fixes the tests which I think we already broken.

Comment thread models/metrics/metrics.go
Comment thread models/v3/schema/types/types.go
Comment thread internal/conn/storage/storage.go
@element-of-surprise element-of-surprise changed the title Removes duplicate issue, moves to better sync.Pool, metrics are on newer format Removes issue where we don't push initial blob, moves to better sync.Pool, metrics are on newer format Sep 23, 2025
@element-of-surprise element-of-surprise merged commit 5f7690d into main Sep 23, 2025
1 check passed
@element-of-surprise element-of-surprise deleted the fixDuplication branch September 23, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants