-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment] Cadl http webpubsub #392
Draft
annelo-msft
wants to merge
22
commits into
Azure:cadl
Choose a base branch
from
annelo-msft:cadl-http-webpubsub
base: cadl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
…not allowing swagger transforms to be applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress: working description of the WebPubSub API in Cadl.
The goal of creating this Cadl description is to determine whether we have parity with the existing DPG v1.0 generator, which generates WebPubSub from swagger. At this point, only a few operations have been described.
Code generated to .NET Template project from this Cadl description can be found in this PR: Azure/azure-sdk-for-net#29499
Outstanding items:
@summary
tag causes a schema_violation error in generated swagger -- need to use@doc
tag for parameter descriptionshub
is a client parameter: Provide a way to indicate that a parameter is a "client parameter" microsoft/typespec#664 -- for now, we are working around this with the swagger transform used in the sdk/webpubsub project.OkResponse
instead ofResponse<200>
: Add untemplated OkResponse to cadl.http microsoft/typespec#666@consumes
per operation? : Allow adding@produces
and@consumes
at the operation level microsoft/typespec#665x-ms-error-response
in the Cadl definition?model
to group input parameters, because we cannot add swagger transforms to$ref
parameters