-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hello world ASA sample to awesome list #160
Conversation
For the |
Hi @gkulin , @hemarina , @rajeshkamal5050 and @savannahostrowski, would you help to review this PR? Thanks! |
@yiliuTo Thanks for the contribution! |
Got it. We will start testing this template. |
@hemarina We have completed the testing of this templates and filed the following issues. Please review and resolve them. |
@hemarina , thanks for the test! And I have created spring-guides/gs-spring-boot-for-azure#24 for the fix, let's wait for the review. |
Hi @hemarina all the issues have been fixed now, could you help to review this PR, thanks! |
@hemarina Three issues have been fixed, currently this template has no issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. CC @jongio in case for more suggestions on repro or bicep files.
I commented here: spring-guides/gs-spring-boot-for-azure#18 (review) |
thanks @jongio for your suggestions, and I have replyed your comments please take a look, thanks |
Hi @jongio @hemarina and @rajeshkamal5050 , could you help to review this PR again? And for the comments from @jongio , we modified the azure.yaml to remove unnecessary configuration options, as for the link format, we would like to keep the adoc way. Hope could get some insights from you, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ship it |
Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.
If you are submitting a new
azd
template to the galleryFill this out if you want your template to be added to the awesome-azd gallery!
GitHub repro link: https://github.com/spring-guides/gs-spring-boot-for-azure
Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:
website/src/data/images/
.In the PR comment, if you can also add a link to the PR where you made your repo
azd
compatible this will allow us to provide feedback on your template and speed up the review process.Make the gs sample compatable with AZD spring-guides/gs-spring-boot-for-azure#18