Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hello world ASA sample to awesome list #160

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

yiliuTo
Copy link
Member

@yiliuTo yiliuTo commented Jun 14, 2023

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

GitHub repro link: https://github.com/spring-guides/gs-spring-boot-for-azure

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
    • Architecture Diagram or Application Screenshot - Used as display image for gallery card. The image should include all services and their connections (example). You should add the image to the website/src/data/images/.
    • Link to Author's GitHub or other relevant website - Used for attribution
    • Author's Name - Name to credit on the gallery card
    • Link to template source - Link to the template GitHub repo
    • Tags - One or more tags representing the template. Provide at least 1 tag for programming language used and at least 1 tag for Azure services integrated. Also tag the IaC provider (Bicep or Terraform). If you don't see a relevant tag for your template? Feel free to add one!
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.
    Make the gs sample compatable with AZD spring-guides/gs-spring-boot-for-azure#18

@yiliuTo
Copy link
Member Author

yiliuTo commented Jun 14, 2023

For the Architecture Diagram or Application Screenshot, since this sample is just an easy hello world application running on Azure Spring Apps, thus its architecture is simple as well, which I personally think may not worth mentioning, and same for the application screen shot. Therefore, I currently use the Azure Spring Apps logo instead, since the goal of us putting the template in awesome-azd is also to promote the ASA support of AZD.

@yiliuTo
Copy link
Member Author

yiliuTo commented Jun 26, 2023

Hi @gkulin , @hemarina , @rajeshkamal5050 and @savannahostrowski, would you help to review this PR? Thanks!

@hemarina
Copy link
Contributor

hemarina commented Jun 26, 2023

@yiliuTo Thanks for the contribution!
@v-xuto Could you validate and test this template when you get a chance? Feel free to reach out if more context needed based on Readme.
cc @rajeshkamal5050 @jongio

@v-xuto
Copy link
Member

v-xuto commented Jun 27, 2023

@yiliuTo Thanks for the contribution! @v-xuto Could you validate and test this template when you get a chance? Feel free to reach out if more context needed based on Readme. cc @rajeshkamal5050 @jongio

Got it. We will start testing this template.

@v-xuto
Copy link
Member

v-xuto commented Jun 29, 2023

@hemarina We have completed the testing of this templates and filed the following issues. Please review and resolve them.

@hemarina
Copy link
Contributor

@hemarina We have completed the testing of this templates and filed the following issues. Please review and resolve them.

@yiliuTo Could you take a look at these issues and resolve them? Let me know if you have any questions.

@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 3, 2023

@hemarina , thanks for the test! And I have created spring-guides/gs-spring-boot-for-azure#24 for the fix, let's wait for the review.

@savannahostrowski savannahostrowski removed their request for review August 3, 2023 17:37
@yiliuTo
Copy link
Member Author

yiliuTo commented Aug 10, 2023

Hi @hemarina all the issues have been fixed now, could you help to review this PR, thanks!

@v-xuto
Copy link
Member

v-xuto commented Aug 11, 2023

@hemarina Three issues have been fixed, currently this template has no issues.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CC @jongio in case for more suggestions on repro or bicep files.

@jongio
Copy link
Member

jongio commented Aug 11, 2023

I commented here: spring-guides/gs-spring-boot-for-azure#18 (review)

@yiliuTo
Copy link
Member Author

yiliuTo commented Aug 15, 2023

thanks @jongio for your suggestions, and I have replyed your comments please take a look, thanks

@yiliuTo
Copy link
Member Author

yiliuTo commented Aug 24, 2023

Hi @jongio @hemarina and @rajeshkamal5050 , could you help to review this PR again? And for the comments from @jongio , we modified the azure.yaml to remove unnecessary configuration options, as for the link format, we would like to keep the adoc way. Hope could get some insights from you, thanks!

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jongio
Copy link
Member

jongio commented Aug 25, 2023

ship it

@hemarina hemarina merged commit 3ff0039 into Azure:main Aug 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants