-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spring-chatgpt-sample template #162
Conversation
Hi @gkulin , @hemarina , @rajeshkamal5050 and @savannahostrowski, would you help to review this PR? Thanks! |
@yiliuTo Thanks for the contribution! |
@hemarina thanks for the quick response, may I know which tests the template should pass? Currently the template can only run in windows/linux/mac os, is that enough? |
Got it. We will start testing this template. |
@hemarina We have completed the testing of this templates and filed the following issues. Please review and resolve them. |
@hemarina yeah I have checked those issues: |
Hi @hemarina , currently all the issues created during the tests have been fixed and closed now, then are we ok to go ahead? |
Hi @jongio would you help to review the template? Thanks! |
IMO having both az and azd methods in readme makes it long, but not a blocker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.
If you are submitting a new
azd
template to the galleryFill this out if you want your template to be added to the awesome-azd gallery!
Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:
website/src/data/images/
.In the PR comment, if you can also add a link to the PR where you made your repo
azd
compatible this will allow us to provide feedback on your template and speed up the review process.Make the sample azd compatible Azure-Samples/spring-chatgpt-sample#2