Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spring-chatgpt-sample template #162

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

yiliuTo
Copy link
Member

@yiliuTo yiliuTo commented Jun 14, 2023

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
    • Architecture Diagram or Application Screenshot - Used as display image for gallery card. The image should include all services and their connections (example). You should add the image to the website/src/data/images/.
    • Link to Author's GitHub or other relevant website - Used for attribution
    • Author's Name - Name to credit on the gallery card
    • Link to template source - Link to the template GitHub repo
    • Tags - One or more tags representing the template. Provide at least 1 tag for programming language used and at least 1 tag for Azure services integrated. Also tag the IaC provider (Bicep or Terraform). If you don't see a relevant tag for your template? Feel free to add one!
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.
    Make the sample azd compatible  Azure-Samples/spring-chatgpt-sample#2

@yiliuTo yiliuTo marked this pull request as ready for review June 15, 2023 06:20
@yiliuTo
Copy link
Member Author

yiliuTo commented Jun 26, 2023

Hi @gkulin , @hemarina , @rajeshkamal5050 and @savannahostrowski, would you help to review this PR? Thanks!

@hemarina
Copy link
Contributor

@yiliuTo Thanks for the contribution!
@v-xuto Could you validate and test this template when you get a chance?
cc @rajeshkamal5050 @jongio

@yiliuTo
Copy link
Member Author

yiliuTo commented Jun 27, 2023

@hemarina thanks for the quick response, may I know which tests the template should pass? Currently the template can only run in windows/linux/mac os, is that enough?

@v-xuto
Copy link
Member

v-xuto commented Jun 27, 2023

@yiliuTo Thanks for the contribution! @v-xuto Could you validate and test this template when you get a chance? cc @rajeshkamal5050 @jongio

Got it. We will start testing this template.

@v-xuto
Copy link
Member

v-xuto commented Jun 29, 2023

@hemarina We have completed the testing of this templates and filed the following issues. Please review and resolve them.

@hemarina
Copy link
Contributor

hemarina commented Jun 30, 2023

@hemarina We have completed the testing of this templates and filed the following issues. Please review and resolve them.

@yiliuTo Tests are about testing azd commands on your repository. Would you mind taking a look at these issues and resolve them? Let me know if you have any questions.

@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 3, 2023

@hemarina yeah I have checked those issues:
Azure-Samples/spring-chatgpt-sample#4 is due to the limitation of Azure OpenAI service so I suppose we can ignore it.
Azure-Samples/spring-chatgpt-sample#5 may be an ASA service issue, I need further information from @v-jiaodi to troubleshoot.

@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 12, 2023

Hi @hemarina , currently all the issues created during the tests have been fixed and closed now, then are we ok to go ahead?

@hemarina
Copy link
Contributor

@yiliuTo Sounds good.
@jongio Would you mind reviewing this template for approval?

@yiliuTo
Copy link
Member Author

yiliuTo commented Jul 20, 2023

Hi @jongio would you help to review the template? Thanks!

@hemarina hemarina requested a review from jongio July 27, 2023 16:24
@jongio
Copy link
Member

jongio commented Jul 27, 2023

IMO having both az and azd methods in readme makes it long, but not a blocker

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

website/src/data/images/asa-chatgpt.png Show resolved Hide resolved
@hemarina hemarina changed the title add ASA chatgpt sample to awesome azd list add spring-chatgpt-sample template Jul 28, 2023
@hemarina hemarina merged commit 4b5fe5e into Azure:main Jul 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants