Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FastAPI, htmx, TailwindCSS Web App with Log Analytics template #163

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

tataraba
Copy link

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

  • [ x ] Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • [ x ] Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
    • [ x ] Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
    • [ x ] Architecture Diagram or Application Screenshot - Used as display image for gallery card. The image should include all services and their connections (example). You should add the image to the website/src/data/images/.
    • [ x ] Link to Author's GitHub or other relevant website - Used for attribution
    • [ x ] Author's Name - Name to credit on the gallery card
    • [ x ] Link to template source - Link to the template GitHub repo
    • [ x ] Tags - One or more tags representing the template. Provide at least 1 tag for programming language used and at least 1 tag for Azure services integrated. Also tag the IaC provider (Bicep or Terraform). If you don't see a relevant tag for your template? Feel free to add one!
  • [ x ] In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

No direct PR, but here's a link to the commit that added most of the stuff for azd with only one modification made afterwards on the uvicorn command.

@tataraba
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Contributor

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very awesome sample! Thanks for contributing @tataraba.

@rajeshkamal5050 let's get this tested!

@rajeshkamal5050
Copy link
Contributor

@rajeshkamal5050 let's get this tested!

hey @v-xuto can we test this?

@v-xuto
Copy link
Member

v-xuto commented Jun 20, 2023

@rajeshkamal5050 let's get this tested!

hey @v-xuto can we test this?

Sure. We will start testing this template https://github.com/tataraba/musicbinder-azd.

@v-xuto
Copy link
Member

v-xuto commented Jun 21, 2023

@rajeshkamal5050 We have completed the testing of this template and filed two issues tataraba/musicbinder-azd#2 and tataraba/musicbinder-azd#3. Please review.

@tataraba
Copy link
Author

@v-xuto @rajeshkamal5050
Both of the issues were resolved.

  1. Converted repo to a template repo, so it should show the button as noted in the README
  2. I was able to deploy using azd up locally, but it wasn't working from Codespaces. Changed the appCommandLine in the bicep file that included single (nested) quotes around the - character and changed to double quotes. I was able to successfully deploy locally and from within Codespaces.

Also, added a command in the Dockerfile (for Codespaces) to install the azd CLI.

Let me know if there's anything else.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CC @jongio for any other thoughts in case if I missed anything.

@jongio
Copy link
Member

jongio commented Jun 22, 2023

I added comments here: tataraba/musicbinder-azd@91d30c6

@tataraba
Copy link
Author

@jongio Made most of the changes recommended on the commit, with exception to using abbreviations.json. Can you advise if you'd like abbreviations added to main.bicep or if I should just remove abbreviations.json altogether to reduce complexity?

@jongio
Copy link
Member

jongio commented Jun 26, 2023

It is up to you to choose if you want to use abbreviations.json, we use it to help us be consistent across all our templates. If you don't want to use it, that is fine. But if you aren't going to use it, then I recommend removing it from your repo.

@tataraba
Copy link
Author

@jongio I added abbreviations.json support and merged to main. Let me know if that looks good or if anything needs to change.

@hemarina
Copy link
Contributor

@jongio abbreviations.json changes looks good to me. I'll merge it to our gallery. Let me know if there're any changes or concerns.

@hemarina hemarina merged commit 6c4895d into Azure:main Jul 31, 2023
2 checks passed
@tataraba tataraba deleted the add-musicbinder-template branch August 1, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants